[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 07/12] vl: Create block backends before setting m
From: |
Markus Armbruster |
Subject: |
[Qemu-block] [PATCH v2 07/12] vl: Create block backends before setting machine properties |
Date: |
Thu, 7 Mar 2019 18:23:56 +0100 |
qemu-system-FOO's main() acts on command line arguments in its own
idiosyncratic order. There's not much method to its madness.
Whenever we find a case where one kind of command line argument needs
to refer to something created for another kind later, we rejigger the
order.
Block devices get created long after machine properties get processed.
Therefore, block device machine properties can be created, but not
set. No such properties exist. But the next commit will create some.
Time to rejigger again: create block devices earlier.
Signed-off-by: Markus Armbruster <address@hidden>
---
vl.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 5a19d2a8ec..c250483fc1 100644
--- a/vl.c
+++ b/vl.c
@@ -4272,6 +4272,13 @@ int main(int argc, char **argv, char **envp)
exit(0);
}
+ /*
+ * Note: we need to create block backends before
+ * machine_set_property(), so machine properties can refer to
+ * them.
+ */
+ configure_blockdev(&bdo_queue, machine_class, snapshot);
+
machine_opts = qemu_get_machine_opts();
qemu_opt_foreach(machine_opts, machine_set_property, current_machine,
&error_fatal);
@@ -4398,8 +4405,6 @@ int main(int argc, char **argv, char **envp)
ram_mig_init();
dirty_bitmap_mig_init();
- configure_blockdev(&bdo_queue, machine_class, snapshot);
-
qemu_opts_foreach(qemu_find_opts("mon"),
mon_init_func, NULL, &error_fatal);
--
2.17.2
- Re: [Qemu-block] [PATCH v2 11/12] pc: Support firmware configuration with -blockdev, (continued)
- [Qemu-block] [PATCH v2 08/12] pflash_cfi01: Add pflash_cfi01_get_blk() helper, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v2 09/12] pc_sysfw: Remove unused PcSysFwDevice, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v2 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v2 10/12] pc_sysfw: Pass PCMachineState to pc_system_firmware_init(), Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v2 05/12] vl: Improve legibility of BlockdevOptions queue, Markus Armbruster, 2019/03/07
- [Qemu-block] [PATCH v2 07/12] vl: Create block backends before setting machine properties,
Markus Armbruster <=
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/08
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/08
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev, no-reply, 2019/03/08