[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 03/10] block: Avoid useless local_err
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 03/10] block: Avoid useless local_err |
Date: |
Mon, 11 Mar 2019 21:53:44 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/11/19 11:50 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
> diff --git a/block.c b/block.c
> index ccf008c177..e18bd5eefd 100644
> --- a/block.c
> +++ b/block.c
> @@ -3155,14 +3155,12 @@ int bdrv_reopen_multiple(AioContext *ctx,
> BlockReopenQueue *bs_queue, Error **er
> {
> int ret = -1;
> BlockReopenQueueEntry *bs_entry, *next;
> - Error *local_err = NULL;
>
> assert(bs_queue != NULL);
>
> QSIMPLEQ_FOREACH(bs_entry, bs_queue, entry) {
> assert(bs_entry->state.bs->quiesce_counter > 0);
> - if (bdrv_reopen_prepare(&bs_entry->state, bs_queue, &local_err)) {
> - error_propagate(errp, local_err);
> + if (bdrv_reopen_prepare(&bs_entry->state, bs_queue, errp)) {
> goto cleanup;
> }
> bs_entry->prepared = true;
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v2 10/10] file-posix: Make auto-read-only dynamic, (continued)
[Qemu-block] [PATCH v2 09/10] file-posix: Prepare permission code for fd switching, Kevin Wolf, 2019/03/11
[Qemu-block] [PATCH v2 08/10] file-posix: Lock new fd in raw_reopen_prepare(), Kevin Wolf, 2019/03/11
[Qemu-block] [PATCH v2 07/10] file-posix: Store BDRVRawState.reopen_state during reopen, Kevin Wolf, 2019/03/11
[Qemu-block] [PATCH v2 06/10] file-posix: Factor out raw_reconfigure_getfd(), Kevin Wolf, 2019/03/11
[Qemu-block] [PATCH v2 05/10] file-posix: Fix bdrv_open_flags() for snapshot=on, Kevin Wolf, 2019/03/11
[Qemu-block] [PATCH v2 04/10] block: Make permission changes in reopen less wrong, Kevin Wolf, 2019/03/11
[Qemu-block] [PATCH v2 03/10] block: Avoid useless local_err, Kevin Wolf, 2019/03/11
[Qemu-block] [PATCH v2 02/10] qemu-iotests: commit to backing file with auto-read-only, Kevin Wolf, 2019/03/11
[Qemu-block] [PATCH v2 01/10] tests/virtio-blk-test: Disable auto-read-only, Kevin Wolf, 2019/03/11
Re: [Qemu-block] [PATCH v2 00/10] file-posix: Make auto-read-only dynamic, Peter Krempa, 2019/03/11