qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 7d04c2: xhci: remove XHCIRing->base (unused)

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 7d04c2: xhci: remove XHCIRing->base (unused)
Date: Tue, 23 Apr 2013 11:00:12 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7d04c2b75562664a28612d7481f328ee4ec51dda
      
https://github.com/qemu/qemu/commit/7d04c2b75562664a28612d7481f328ee4ec51dda
  Author: Gerd Hoffmann <address@hidden>
  Date:   2013-04-22 (Mon, 22 Apr 2013)

  Changed paths:
    M hw/usb/hcd-xhci.c

  Log Message:
  -----------
  xhci: remove XHCIRing->base (unused)

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e449f26bed42b1d8c6efefcd8dc768f23f19458f
      
https://github.com/qemu/qemu/commit/e449f26bed42b1d8c6efefcd8dc768f23f19458f
  Author: Hans de Goede <address@hidden>
  Date:   2013-04-22 (Mon, 22 Apr 2013)

  Changed paths:
    M hw/usb/hcd-ehci.c

  Log Message:
  -----------
  ehci_free_packet: Discard finished packets when the queue is halted

With pipelining it is possible to encounter a finished packet when cleaning
the queue due to a halt. This happens when a non stall error happens while
talking to a real device. In this case the queue on the usb-host side will
continue processing packets, and we can have completed packets waiting in
the queue after an error condition packet causing a halt.

There are 2 reasons to discard the completed packets at this point, rather
then trying to writing them back to the guest:

1) The guest expect to be able to cancel and/or change packets after the
packet with the error without doing an unlink, so writing them back may
confuse the guest.

2) Since the queue does not advance when halted, the writing back of these
packets will fail anyways since p->qtdaddr != q->qtdaddr, so the
ehci_verify_qtd call in ehci_writeback_async_complete_packet will fail.

Note that 2) means that then only functional change this patch introduces
is the printing of a warning when this scenario happens.

Note that discarding these packets means that the guest driver and the device
will get out of sync! This is unfortunate, but should not be a problem since
with a non stall error (iow an io-error) the 2 are out of sync already anyways.
Still this patch adds a warning to signal this happening.

Note that sofar this has only been seen with a DVB-T receiver, which gives
of a MPEG-2 stream, which allows for recovering from lost packets, see:
https://bugzilla.redhat.com/show_bug.cgi?id=890320

Signed-off-by: Hans de Goede <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3b7e759a4110690c9617b1ffa6a7c96a343a330d
      
https://github.com/qemu/qemu/commit/3b7e759a4110690c9617b1ffa6a7c96a343a330d
  Author: Gerd Hoffmann <address@hidden>
  Date:   2013-04-22 (Mon, 22 Apr 2013)

  Changed paths:
    M hw/usb/bus.c
    M hw/usb/desc.c
    M trace-events

  Log Message:
  -----------
  usb: better speed mismatch error reporting

Report the supported speeds for device and port in the error message.
Also add the speeds to the tracepoint.  And while being at it drop
the redundant error message in usb_desc_attach, usb_device_attach will
report the error anyway.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3f5cc97e2ba00b34fd20a5553ed9d2fecf32f7e3
      
https://github.com/qemu/qemu/commit/3f5cc97e2ba00b34fd20a5553ed9d2fecf32f7e3
  Author: Gerd Hoffmann <address@hidden>
  Date:   2013-04-22 (Mon, 22 Apr 2013)

  Changed paths:
    M configure
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  usb-host: raise libusbx minimum version to 1.0.13

Allows to remove one FIXME.  Makes LIBUSB_LOG_LEVEL_WARNING build errors
go away.  And starting with that version libusb has a LIBUSBX_API_VERSION
define which allows to easily #ifdef version dependencies should that
need arrive in the future.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2cfd5cc06ab14879964c8bbd5595d416490605ea
      
https://github.com/qemu/qemu/commit/2cfd5cc06ab14879964c8bbd5595d416490605ea
  Author: Anthony Liguori <address@hidden>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M configure
    M hw/usb/bus.c
    M hw/usb/desc.c
    M hw/usb/hcd-ehci.c
    M hw/usb/hcd-xhci.c
    M hw/usb/host-libusb.c
    M trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 'kraxel/usb.81' into staging

# By Gerd Hoffmann (3) and Hans de Goede (1)
# Via Gerd Hoffmann
* kraxel/usb.81:
  usb-host: raise libusbx minimum version to 1.0.13
  usb: better speed mismatch error reporting
  ehci_free_packet: Discard finished packets when the queue is halted
  xhci: remove XHCIRing->base (unused)

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 571253d410d6050637ccd3b6c122a3ad61e2ab25
      
https://github.com/qemu/qemu/commit/571253d410d6050637ccd3b6c122a3ad61e2ab25
  Author: Ozan Çağlayan <address@hidden>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: Use gtk_widget_get_window() to support both gtk2 and gtk3

This fixes build with gtk+-3.0.

Signed-off-by: Ozan Çağlayan <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 93b971c4ff0881349d4fa5a1394cc3d6faf351c3
      
https://github.com/qemu/qemu/commit/93b971c4ff0881349d4fa5a1394cc3d6faf351c3
  Author: Ozan Çağlayan <address@hidden>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    A po/tr.po

  Log Message:
  -----------
  ui/gtk: Add Turkish translations

Signed-off-by: Ozan Çağlayan <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: e7303c43031302279ee7b5d6ea7031bf81e2e2d9
      
https://github.com/qemu/qemu/commit/e7303c43031302279ee7b5d6ea7031bf81e2e2d9
  Author: KONRAD Frederic <address@hidden>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M hw/9pfs/virtio-9p-device.c
    M hw/9pfs/virtio-9p.h
    M hw/virtio/virtio-pci.c

  Log Message:
  -----------
  virtio-9p: add the virtio-9p device.

Create virtio-9p-device which extends virtio-device, so it can be connected on
virtio-bus.

Signed-off-by: KONRAD Frederic <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 234a336f9e308ae60ad8ef8f2662eb0a93d7ff00
      
https://github.com/qemu/qemu/commit/234a336f9e308ae60ad8ef8f2662eb0a93d7ff00
  Author: KONRAD Frederic <address@hidden>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M hw/9pfs/virtio-9p.h
    M hw/virtio/virtio-pci.c
    M hw/virtio/virtio-pci.h

  Log Message:
  -----------
  virtio-9p-pci: switch to the new API.

Here the virtio-9p-pci is modified for the new API. The device
virtio-9p-pci extends virtio-pci. It creates and connects a
virtio-9p-device during the init. The properties are not changed.

Signed-off-by: KONRAD Frederic <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: e8111e50557761b0d86cd5c90fe7a272aeddd7a3
      
https://github.com/qemu/qemu/commit/e8111e50557761b0d86cd5c90fe7a272aeddd7a3
  Author: KONRAD Frederic <address@hidden>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M hw/9pfs/virtio-9p-device.c

  Log Message:
  -----------
  virtio-9p: cleanup: init function.

This remove old init function as it is no longer needed.

Signed-off-by: KONRAD Frederic <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 13daf6cad05a65970381cd8b876426d55133aadf
      
https://github.com/qemu/qemu/commit/13daf6cad05a65970381cd8b876426d55133aadf
  Author: KONRAD Frederic <address@hidden>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M hw/9pfs/virtio-9p-device.c
    M hw/9pfs/virtio-9p.c
    M hw/9pfs/virtio-9p.h

  Log Message:
  -----------
  virtio-9p: cleanup: QOM casts.

As the virtio-9p-pci is switched to the new API, we can use QOM casts.

Signed-off-by: KONRAD Frederic <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: bb71623811686ce3c34ce724f073f5c5dd95f51b
      
https://github.com/qemu/qemu/commit/bb71623811686ce3c34ce724f073f5c5dd95f51b
  Author: Stefan Berger <address@hidden>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_passthrough.c
    M include/sysemu/tpm_backend.h
    M tpm.c
    M vl.c

  Log Message:
  -----------
  Move TPM passthrough specific command line options to backend structure

Move the TPM passthrough specific command line options to the passthrough
backend implementation and attach them to the backend's interface structure.

Add code to tpm.c for validating the TPM command line options.

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Corey Bryan <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/456736710df1...bb7162381168
reply via email to
[Prev in Thread] Current Thread [Next in Thread]