qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 99c62e: MAINTAINERS: Promote NBD to supported

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 99c62e: MAINTAINERS: Promote NBD to supported, with new ma...
Date: Mon, 10 Jul 2017 08:51:51 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 99c62e70aaa9a3ad843ab1a58129104f83f366db
      
https://github.com/qemu/qemu/commit/99c62e70aaa9a3ad843ab1a58129104f83f366db
  Author: Eric Blake <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Promote NBD to supported, with new maintainer

We are promising more than just odd fixes, and Paolo is hoping
to offload the pull requests to me.  Also, enough of NBD is related
to the block layer that it is worth including qemu-block on patches.

While at it, include blockdev-nbd.c and qemu-nbd.texi in the set
of maintained files.

Signed-off-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>


  Commit: 1e120ffead85d08d41160065e0d8cf86400b1c9e
      
https://github.com/qemu/qemu/commit/1e120ffead85d08d41160065e0d8cf86400b1c9e
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT

Separate the case when a client sends NBD_OPT_ABORT from all other
errors. It will be needed for the following patch, where errors will be
reported.
This particular case is not actually an error - it honestly follows the
NBD protocol. Therefore it should not be reported like an error.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: 76ff081d91d215a4f91849653bdc2ebd8f657183
      
https://github.com/qemu/qemu/commit/76ff081d91d215a4f91849653bdc2ebd8f657183
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd/server: refactor nbd_negotiate

Combine two successive "if (oldStyle) {...} else {...}" into one.

Block "if (client->tlscreds)" under "if (oldStyle)" is unreachable,
as we have "oldStyle = client->exp != NULL && !client->tlscreds;".
So, delete this block.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: 2fd2c8407ea508e0fac0beb1aa0ec52d6964749c
      
https://github.com/qemu/qemu/commit/2fd2c8407ea508e0fac0beb1aa0ec52d6964749c
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd/server: use errp instead of LOG

Move to modern errp scheme from just LOGging errors.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: c7b9728250e50bfaf3e3f8e84a6206cd49b07776
      
https://github.com/qemu/qemu/commit/c7b9728250e50bfaf3e3f8e84a6206cd49b07776
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd/server: add errp to nbd_send_reply()

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: 3e6bb543c208cb1f184c0f3d52e5f4e77e1e8957
      
https://github.com/qemu/qemu/commit/3e6bb543c208cb1f184c0f3d52e5f4e77e1e8957
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/common.c

  Log Message:
  -----------
  nbd/common: nbd_tls_handshake: remove extra TRACE

Error is propagated to the caller, TRACE is not needed.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: 458d7a693948130bc823d2f90fce659353a04eb6
      
https://github.com/qemu/qemu/commit/458d7a693948130bc823d2f90fce659353a04eb6
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/client.c

  Log Message:
  -----------
  nbd/client: refactor TRACE of NBD_MAGIC

We are going to switch from TRACE macro to trace points,
this TRACE complicates things, this patch simplifies it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: 487519616307a563bc730ec96ea77a9811d2ee59
      
https://github.com/qemu/qemu/commit/487519616307a563bc730ec96ea77a9811d2ee59
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd/server: fix TRACE in nbd_negotiate_send_rep_len

Fix wrong order of TRACE arguments.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: 7f9039cdaa43f7d93d60e739ce9436ff0788cbb4
      
https://github.com/qemu/qemu/commit/7f9039cdaa43f7d93d60e739ce9436ff0788cbb4
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd/server: rename clientflags var in nbd_negotiate_options

Rename 'clientflags' to just 'option'. This variable has nothing to do
with flags, but is a single integer representing the option requested
by the client.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: 6fb2b9726c4e9f613bdda800d0a529c099696694
      
https://github.com/qemu/qemu/commit/6fb2b9726c4e9f613bdda800d0a529c099696694
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M nbd/client.c
    M nbd/server.c

  Log Message:
  -----------
  nbd: refactor tracing

Reorganize traces: move, reword, add information, drop extra ones.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>


  Commit: 9588463e747706ffbaf6f4600b5efea2779bc26f
      
https://github.com/qemu/qemu/commit/9588463e747706ffbaf6f4600b5efea2779bc26f
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M Makefile.objs
    M nbd/client.c
    M nbd/nbd-internal.h
    M nbd/server.c
    A nbd/trace-events

  Log Message:
  -----------
  nbd: use generic trace subsystem instead of TRACE macro

Let NBD use the trace mechanisms already present in qemu. Now you can
use the -trace optino of qemu, or the -T/--trace option of qemu-img,
qemu-io, and qemu-nbd, to select nbd traces. For qemu, the QMP commands
trace-event-{get,set}-state can also toggle tracing on the fly.

Example:
   qemu-nbd --trace 'nbd_*' <image file> # enables all nbd traces

Recompilation with CFLAGS=-DDEBUG_NBD is no more needed, furthermore,
DEBUG_NBD macro is removed from the code.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
[eblake: minor tweaks to a couple of traces]
Signed-off-by: Eric Blake <address@hidden>


  Commit: 6b06e3e49eb8c91cc286c16d6bf3181ac296f33d
      
https://github.com/qemu/qemu/commit/6b06e3e49eb8c91cc286c16d6bf3181ac296f33d
  Author: Peter Maydell <address@hidden>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M MAINTAINERS
    M Makefile.objs
    M nbd/client.c
    M nbd/common.c
    M nbd/nbd-internal.h
    M nbd/server.c
    A nbd/trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2017-07-10-v2' into 
staging

nbd patches for 2017-07-10

- Eric Blake: MAINTAINERS: Promote NBD to supported, with new maintainer
- Vladimir Sementsov-Ogievskiy: [00/10] nbd refactoring part 2

# gpg: Signature made Mon 10 Jul 2017 15:59:18 BST
# gpg:                using RSA key 0xA7A16B4A2527436A
# gpg: Good signature from "Eric Blake <address@hidden>"
# gpg:                 aka "Eric Blake (Free Software Programmer) 
<address@hidden>"
# gpg:                 aka "[jpeg image of size 6874]"
# Primary key fingerprint: 71C2 CC22 B1C4 6029 27D2  F3AA A7A1 6B4A 2527 436A

* remotes/ericb/tags/pull-nbd-2017-07-10-v2:
  nbd: use generic trace subsystem instead of TRACE macro
  nbd: refactor tracing
  nbd/server: rename clientflags var in nbd_negotiate_options
  nbd/server: fix TRACE in nbd_negotiate_send_rep_len
  nbd/client: refactor TRACE of NBD_MAGIC
  nbd/common: nbd_tls_handshake: remove extra TRACE
  nbd/server: add errp to nbd_send_reply()
  nbd/server: use errp instead of LOG
  nbd/server: refactor nbd_negotiate
  nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT
  MAINTAINERS: Promote NBD to supported, with new maintainer

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/94c56652b907...6b06e3e49eb8
reply via email to
[Prev in Thread] Current Thread [Next in Thread]