[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bb3ba3: linux-user: check that all of AArch64

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] bb3ba3: linux-user: check that all of AArch64 SVE extended...
Date: Tue, 17 Apr 2018 04:52:01 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bb3ba35f20a42941140676264a41525efac984d9
  Author: Peter Maydell <address@hidden>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M linux-user/signal.c

  Log Message:
  linux-user: check that all of AArch64 SVE extended sigframe is writable

In commit 8c5931de0ac7738809 we added support for SVE extended
sigframe records.  These mean that the signal frame might now be
larger than the size of the target_rt_sigframe record, so make sure
we call lock_user on the entire frame size when we're creating it.
(The code for restoring the signal frame already correctly handles
the extended records by locking the 'extra' section separately to the
main section.)

In particular, this fixes a bug even for non-SVE signal frames,
because it extends the locked section to cover the
target_rt_frame_record. Previously this was part of 'struct
target_rt_sigframe', but in commit e1eecd1d9d4c1ade3 we pulled
it out into its own struct, and so locking the target_rt_sigframe
alone doesn't cover it. This bug would mean that we would fail
to correctly handle the case where a signal was taken with
SP pointing 16 bytes into an unwritable page, with the page
immediately below it in memory being writable.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]