[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 0efc91: migration: fix exec/fd migrations
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 0efc91: migration: fix exec/fd migrations |
Date: |
Tue, 29 May 2018 01:56:52 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 0efc91423a77ba6dc4a2f6d96a1ae1f5d3d958a8
https://github.com/qemu/qemu/commit/0efc91423a77ba6dc4a2f6d96a1ae1f5d3d958a8
Author: Juan Quintela <address@hidden>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M migration/exec.c
M migration/fd.c
Log Message:
-----------
migration: fix exec/fd migrations
Commit:
commit 36c2f8be2c4eb0003ac77a14910842b7ddd7337e
Author: Juan Quintela <address@hidden>
Date: Wed Mar 7 08:40:52 2018 +0100
migration: Delay start of migration main routines
Missed tcp and fd transports. This fix its.
Reported-by: Kevin Wolf <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
Tested-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
Commit: bf269906f5b225a04825b2bce4364bfe1d509999
https://github.com/qemu/qemu/commit/bf269906f5b225a04825b2bce4364bfe1d509999
Author: Peter Xu <address@hidden>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M migration/ram.c
Log Message:
-----------
migration: use g_free for ram load bitmap
Buffers allocated with bitmap_new() should be freed with g_free().
Both reported by Coverity:
*** CID 1391300: API usage errors (ALLOC_FREE_MISMATCH)
/migration/ram.c: 3517 in ram_dirty_bitmap_reload()
3511 * the last one to sync, we need to notify the main send thread.
3512 */
3513 ram_dirty_bitmap_reload_notify(s);
3514
3515 ret = 0;
3516 out:
>>> CID 1391300: API usage errors (ALLOC_FREE_MISMATCH)
>>> Calling "free" frees "le_bitmap" using "free" but it should have been
>>> freed using "g_free".
3517 free(le_bitmap);
3518 return ret;
3519 }
3520
3521 static int ram_resume_prepare(MigrationState *s, void *opaque)
3522 {
*** CID 1391292: API usage errors (ALLOC_FREE_MISMATCH)
/migration/ram.c: 249 in ramblock_recv_bitmap_send()
243 * Mark as an end, in case the middle part is screwed up due to
244 * some "misterious" reason.
245 */
246 qemu_put_be64(file, RAMBLOCK_RECV_BITMAP_ENDING);
247 qemu_fflush(file);
248
>>> CID 1391292: API usage errors (ALLOC_FREE_MISMATCH)
>>> Calling "free" frees "le_bitmap" using "free" but it should have been
>>> freed using "g_free".
249 free(le_bitmap);
250
251 if (qemu_file_get_error(file)) {
252 return qemu_file_get_error(file);
253 }
254
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
Commit: 98c0a88ea31140d2fdb0eac9c153212d036f6d0d
https://github.com/qemu/qemu/commit/98c0a88ea31140d2fdb0eac9c153212d036f6d0d
Author: Peter Maydell <address@hidden>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M migration/exec.c
M migration/fd.c
M migration/ram.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20180525'
into staging
migration/next for 20180525
# gpg: Signature made Fri 25 May 2018 14:30:47 BST
# gpg: using RSA key F487EF185872D723
# gpg: Good signature from "Juan Quintela <address@hidden>"
# gpg: aka "Juan Quintela <address@hidden>"
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03 4B82 F487 EF18 5872 D723
* remotes/juanquintela/tags/migration/20180525:
migration: use g_free for ram load bitmap
migration: fix exec/fd migrations
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/5a5c383b1373...98c0a88ea311
**NOTE:** This service been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 0efc91: migration: fix exec/fd migrations,
GitHub <=