[Qemu-commits] [qemu/qemu] 751522: hw/rdma: Make distinction between device init and ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 751522275a800c0d1c215b386a17f537bc76cd37
      
https://github.com/qemu/qemu/commit/751522275a800c0d1c215b386a17f537bc76cd37
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_backend.h
    M hw/rdma/rdma_backend_defs.h
    M hw/rdma/vmw/pvrdma_main.c

  Log Message:
  -----------
  hw/rdma: Make distinction between device init and start modes

There are certain operations that are well considered as part of device
configuration while others are needed only when "start" command is
triggered by the guest driver. An example of device initialization step
is msix_init and example of "device start" stage is the creation of a CQ
completion handler thread.

Driver expects such distinction - implement it.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: b462a1348031e4731b25abd615529f56cc524bc1
      
https://github.com/qemu/qemu/commit/b462a1348031e4731b25abd615529f56cc524bc1
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/vmw/pvrdma_cmd.c

  Log Message:
  -----------
  hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp

Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error
where backend query_qp fails to retrieve the needed QP attributes.
Fix it by providing the attr_mask we got from driver.

Signed-off-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: ef846e026c30c39239500d0b91b26d4fecc1f1d0
      
https://github.com/qemu/qemu/commit/ef846e026c30c39239500d0b91b26d4fecc1f1d0
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_utils.c
    M hw/rdma/rdma_utils.h
    M hw/rdma/vmw/pvrdma_main.c

  Log Message:
  -----------
  hw/rdma: Modify debug macros

- Add line counter to ease navigation in log
- Print rdma instead of pvrdma

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: eca0f2a6be86602a82edcd90ecd8f4a57b0c8007
      
https://github.com/qemu/qemu/commit/eca0f2a6be86602a82edcd90ecd8f4a57b0c8007
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/vmw/pvrdma_qp_ops.c

  Log Message:
  -----------
  hw/pvrdma: Clean CQE before use

Next CQE is fetched from CQ ring, clean it before usage as it still
carries old CQE values.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 6e7dba23af1a8f30eac42022cfb94d8693ed20e2
      
https://github.com/qemu/qemu/commit/6e7dba23af1a8f30eac42022cfb94d8693ed20e2
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/vmw/pvrdma.h
    M hw/rdma/vmw/pvrdma_cmd.c

  Log Message:
  -----------
  hw/pvrdma: Make default pkey 0xFFFF

0x7FFF is not the default pkey - fix it.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 7f99daadbddfee16f3ee77c413bd4a34366a3dad
      
https://github.com/qemu/qemu/commit/7f99daadbddfee16f3ee77c413bd4a34366a3dad
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_rm.c
    M hw/rdma/rdma_rm_defs.h

  Log Message:
  -----------
  hw/rdma: Delete useless structure RdmaRmUserMR

The structure RdmaRmUserMR has no benefits, remove it an move all its
fields to struct RdmaRmMR.

Reviewed-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 4c408c9d5b3f648a2f100edf6287a7c7ce63f634
      
https://github.com/qemu/qemu/commit/4c408c9d5b3f648a2f100edf6287a7c7ce63f634
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_rm.c

  Log Message:
  -----------
  hw/rdma: Do not allocate memory for non-dma MR

There is no use in the memory allocated for non-dma MR.
Delete the code that allocates it.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 7131c4b028b09c8545a16614b38aefdd4a77b0b4
      
https://github.com/qemu/qemu/commit/7131c4b028b09c8545a16614b38aefdd4a77b0b4
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_rm.c

  Log Message:
  -----------
  hw/rdma: Reorder resource cleanup

To be consistence with allocation do the reverse order in deallocation

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 67b32fe250a0a9759e4ead14bdcc1d992dd9bf44
      
https://github.com/qemu/qemu/commit/67b32fe250a0a9759e4ead14bdcc1d992dd9bf44
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/vmw/pvrdma_main.c

  Log Message:
  -----------
  hw/pvrdma: Cosmetic change - indent right

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 292dce627b51329212130470f485b7dc2b72b48c
      
https://github.com/qemu/qemu/commit/292dce627b51329212130470f485b7dc2b72b48c
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_backend.c

  Log Message:
  -----------
  hw/rdma: Cosmetic change - move to generic function

To ease maintenance of struct comp_thread move all related code to
dedicated function.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: abc665aae30a6fa3b6bb6784b535ab656461abd3
      
https://github.com/qemu/qemu/commit/abc665aae30a6fa3b6bb6784b535ab656461abd3
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_rm.c
    M hw/rdma/vmw/pvrdma_qp_ops.c

  Log Message:
  -----------
  hw/rdma: Print backend QP number in hex format

To be consistent with other prints throughout the code fix places that
print it as decimal number.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 7d2ce4b0169e6bd2bb1b87eb69f1fae96c854ffc
      
https://github.com/qemu/qemu/commit/7d2ce4b0169e6bd2bb1b87eb69f1fae96c854ffc
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_rm.c
    M hw/rdma/vmw/pvrdma_cmd.c

  Log Message:
  -----------
  hw/rdma: Bugfix - Support non-aligned buffers

RDMA application can provide non-aligned buffers to be registered. In
such case the DMA address passed by driver is pointing to the beginning
of the physical address of the mapped page so we can't distinguish
between two addresses from the same page.

Fix it by keeping the offset of the virtual address in mr->virt.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 430e440c59e8a6bcf8806576f37470641298af31
      
https://github.com/qemu/qemu/commit/430e440c59e8a6bcf8806576f37470641298af31
  Author: Yuval Shaia <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_backend.h
    M hw/rdma/vmw/pvrdma_main.c

  Log Message:
  -----------
  hw/rdma: Add reference to pci_dev in backend_dev

The field backend_dev->dev is not initialized, fix it.

Signed-off-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 72221d03b85fcfba27a47a2af08ee59150550ced
      
https://github.com/qemu/qemu/commit/72221d03b85fcfba27a47a2af08ee59150550ced
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M hw/rdma/vmw/pvrdma_cmd.c

  Log Message:
  -----------
  hw/pvrdma: remove not needed include

No need to include linux/types.h, is empty anyway.

Suggested-by: Thomas Huth <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Yuval Shaia <address@hidden>


  Commit: 21ab34c9543fe1b6d31b3edbd01a397e7e090d00
      
https://github.com/qemu/qemu/commit/21ab34c9543fe1b6d31b3edbd01a397e7e090d00
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2018-08-18 (Sat, 18 Aug 2018)

  Changed paths:
    M configure
    M hw/rdma/Makefile.objs

  Log Message:
  -----------
  config: split PVRDMA from RDMA

In some BSD systems RDMA migration is possible while
the pvrdma device can't be used because the mremap system call
is missing.

Reported-by: Rebecca Cran <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>


  Commit: c8090972fa85b197411b530ddf81a2867379406c
      
https://github.com/qemu/qemu/commit/c8090972fa85b197411b530ddf81a2867379406c
  Author: Peter Maydell <address@hidden>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M configure
    M hw/rdma/Makefile.objs
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_backend.h
    M hw/rdma/rdma_backend_defs.h
    M hw/rdma/rdma_rm.c
    M hw/rdma/rdma_rm_defs.h
    M hw/rdma/rdma_utils.c
    M hw/rdma/rdma_utils.h
    M hw/rdma/vmw/pvrdma.h
    M hw/rdma/vmw/pvrdma_cmd.c
    M hw/rdma/vmw/pvrdma_main.c
    M hw/rdma/vmw/pvrdma_qp_ops.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into 
staging

RDMA queue

# gpg: Signature made Sat 18 Aug 2018 16:01:46 BST
# gpg:                using RSA key 36D4C0F0CF2FE46D
# gpg: Good signature from "Marcel Apfelbaum <address@hidden>"
# gpg:                 aka "Marcel Apfelbaum <address@hidden>"
# gpg:                 aka "Marcel Apfelbaum <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: B1C6 3A57 F92E 08F2 640F  31F5 36D4 C0F0 CF2F E46D

* remotes/marcel/tags/rdma-pull-request:
  config: split PVRDMA from RDMA
  hw/pvrdma: remove not needed include
  hw/rdma: Add reference to pci_dev in backend_dev
  hw/rdma: Bugfix - Support non-aligned buffers
  hw/rdma: Print backend QP number in hex format
  hw/rdma: Cosmetic change - move to generic function
  hw/pvrdma: Cosmetic change - indent right
  hw/rdma: Reorder resource cleanup
  hw/rdma: Do not allocate memory for non-dma MR
  hw/rdma: Delete useless structure RdmaRmUserMR
  hw/pvrdma: Make default pkey 0xFFFF
  hw/pvrdma: Clean CQE before use
  hw/rdma: Modify debug macros
  hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp
  hw/rdma: Make distinction between device init and start modes

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/62c34848efb4...c8090972fa85
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.