[Qemu-commits] [qemu/qemu] 850d5e: linux-user: Suppress address-of-packed-member warn...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 850d5e330a9c68cc998cecc02caf8a3c8d1ee8a3
      
https://github.com/qemu/qemu/commit/850d5e330a9c68cc998cecc02caf8a3c8d1ee8a3
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-18 (Thu, 18 Oct 2018)

  Changed paths:
    M linux-user/qemu.h

  Log Message:
  -----------
  linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

Our __get_user_e() and __put_user_e() macros cause newer versions
of clang to generate false-positive -Waddress-of-packed-member
warnings if they are passed the address of a member of a packed
struct (see https://bugs.llvm.org/show_bug.cgi?id=39113).
Suppress these using the _Pragma() operator. Unfortunately
_Pragma() support in gcc is broken in some gcc versions and
in some usage contexts, so we limit the pragma usage here to clang.

To put in the pragmas we need to convert the macros from
expressions to statements, but all the callsites effectively
treat them as statements already so this is OK.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 6d5bb0b896f9954c98d85c8835a75bb3a041de41
      
https://github.com/qemu/qemu/commit/6d5bb0b896f9954c98d85c8835a75bb3a041de41
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-18 (Thu, 18 Oct 2018)

  Changed paths:
    M linux-user/sparc/signal.c

  Log Message:
  -----------
  linux-user/sparc/signal.c: Remove unnecessary comment

Remove a comment suggesting that we need to call tb_flush()
after writing the SPARC signal frame trampoline insns.
This isn't necessary in QEMU, because (even if the guest
architecture requires explicit icache maintenance) we
ensure that memory writes result in invalidation of
translated code from that memory.

Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 1b7490446bf41f54130c2d495dd4c8768c8e1ce3
      
https://github.com/qemu/qemu/commit/1b7490446bf41f54130c2d495dd4c8768c8e1ce3
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-19 (Fri, 19 Oct 2018)

  Changed paths:
    M linux-user/qemu.h
    M linux-user/sparc/signal.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging

Add a workaround for clang bug and remove misleading comment (sparc)

# gpg: Signature made Thu 18 Oct 2018 20:00:17 BST
# gpg:                using RSA key F30C38BD3F2FBE3C
# gpg: Good signature from "Laurent Vivier <address@hidden>"
# gpg:                 aka "Laurent Vivier <address@hidden>"
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>"
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/linux-user-for-3.1-pull-request:
  linux-user/sparc/signal.c: Remove unnecessary comment
  linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2ec24af2379e...1b7490446bf4
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.