[Qemu-commits] [qemu/qemu] a8b826: crypto: Fix defaults in QCryptoBlockCreateOptionsL...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a8b826d47adc5a62cf325482b6da1ba06d143df7
      
https://github.com/qemu/qemu/commit/a8b826d47adc5a62cf325482b6da1ba06d143df7
  Author: Alberto Garcia <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M qapi/crypto.json

  Log Message:
  -----------
  crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS

The values specified in the documentation don't match the actual
defaults set in qcrypto_block_luks_create().

Signed-off-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: b640adca9f6a7f90b0975384b1264617ca8e0284
      
https://github.com/qemu/qemu/commit/b640adca9f6a7f90b0975384b1264617ca8e0284
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M crypto/block-luks.c

  Log Message:
  -----------
  crypto/block-luks: fix memory leak in qcrypto_block_luks_create

Free block->cipher and block->ivgen on error path.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 1dc57b60380aa430b33f9b5d776be3bc1f65081e
      
https://github.com/qemu/qemu/commit/1dc57b60380aa430b33f9b5d776be3bc1f65081e
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M crypto/block.c

  Log Message:
  -----------
  crypto/block: refactor qcrypto_block_*crypt_helper functions

qcrypto_block_encrypt_helper and qcrypto_block_decrypt_helper are
almost identical, let's reduce code duplication and simplify further
improvements.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 0270417c87d330243eb713a3312ea5e39e192994
      
https://github.com/qemu/qemu/commit/0270417c87d330243eb713a3312ea5e39e192994
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M crypto/block-luks.c
    M crypto/block-qcow.c
    M crypto/block.c
    M crypto/blockpriv.h

  Log Message:
  -----------
  crypto/block: rename qcrypto_block_*crypt_helper

Rename qcrypto_block_*crypt_helper to qcrypto_block_cipher_*crypt_helper,
as it's not about QCryptoBlock. This is needed to introduce
qcrypto_block_*crypt_helper in the next commit, which will have
QCryptoBlock pointer and than will be able to use additional fields of
it, which in turn will be used to implement thread-safe QCryptoBlock
operations.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 0f0d596cb16a43314c8bc4a9afa2f966203fb05f
      
https://github.com/qemu/qemu/commit/0f0d596cb16a43314c8bc4a9afa2f966203fb05f
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M crypto/block-luks.c
    M crypto/block-qcow.c
    M crypto/block.c
    M crypto/blockpriv.h

  Log Message:
  -----------
  crypto/block: introduce qcrypto_block_*crypt_helper functions

Introduce QCryptoBlock-based functions and use them where possible.
This is needed to implement thread-safe encrypt/decrypt operations.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: c972fa123c73501b4b0c6de7873754ea3205a5eb
      
https://github.com/qemu/qemu/commit/c972fa123c73501b4b0c6de7873754ea3205a5eb
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M block/crypto.c
    M block/qcow.c
    M block/qcow2.c
    M crypto/block-luks.c
    M crypto/block-qcow.c
    M crypto/block.c
    M crypto/blockpriv.h
    M include/crypto/block.h
    M tests/test-crypto-block.c

  Log Message:
  -----------
  crypto: support multiple threads accessing one QCryptoBlock

The two thing that should be handled are cipher and ivgen. For ivgen
the solution is just mutex, as iv calculations should not be long in
comparison with encryption/decryption. And for cipher let's just keep
per-thread ciphers.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: d8d5fefd8657d4f7b380b3a1533340434b5b9def
      
https://github.com/qemu/qemu/commit/d8d5fefd8657d4f7b380b3a1533340434b5b9def
  Author: Peter Maydell <address@hidden>
  Date:   2018-12-13 (Thu, 13 Dec 2018)

  Changed paths:
    M block/crypto.c
    M block/qcow.c
    M block/qcow2.c
    M crypto/block-luks.c
    M crypto/block-qcow.c
    M crypto/block.c
    M crypto/blockpriv.h
    M include/crypto/block.h
    M qapi/crypto.json
    M tests/test-crypto-block.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/berrange/tags/qcrypto-next-pull-request' into staging

Merge crypto patches 2018/12/12

 - Fix documentation about default LUKS algorithms
 - Support for multi-threaded block crypto

# gpg: Signature made Wed 12 Dec 2018 11:21:52 GMT
# gpg:                using RSA key BE86EBB415104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>"
# gpg:                 aka "Daniel P. Berrange <address@hidden>"
# Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E  8E3F BE86 EBB4 1510 4FDF

* remotes/berrange/tags/qcrypto-next-pull-request:
  crypto: support multiple threads accessing one QCryptoBlock
  crypto/block: introduce qcrypto_block_*crypt_helper functions
  crypto/block: rename qcrypto_block_*crypt_helper
  crypto/block: refactor qcrypto_block_*crypt_helper functions
  crypto/block-luks: fix memory leak in qcrypto_block_luks_create
  crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2d894e48362a...d8d5fefd8657
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.