[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 55281a: hw/s390/ccw.c: Don't take address of
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 55281a: hw/s390/ccw.c: Don't take address of packed member... |
Date: |
Fri, 21 Dec 2018 06:05:29 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 55281a2c53b884d0c2bce31aee592faf20a28eed
https://github.com/qemu/qemu/commit/55281a2c53b884d0c2bce31aee592faf20a28eed
Author: Peter Maydell <address@hidden>
Date: 2018-12-20 (Thu, 20 Dec 2018)
Changed paths:
M hw/s390x/css.c
Log Message:
-----------
hw/s390/ccw.c: Don't take address of packed members
Taking the address of a field in a packed struct is a bad idea, because
it might not be actually aligned enough for that pointer type (and
thus cause a crash on dereference on some host architectures). Newer
versions of clang warn about this.
Avoid the problem by using local copies of the PMCW and SCSW
struct fields in copy_schib_from_guest() and copy_schib_to_guest().
Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Farhan Ali <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
Commit: aba7a5a2de3dba5917024df25441f715b9249e31
https://github.com/qemu/qemu/commit/aba7a5a2de3dba5917024df25441f715b9249e31
Author: Thomas Huth <address@hidden>
Date: 2018-12-20 (Thu, 20 Dec 2018)
Changed paths:
M include/hw/s390x/tod.h
Log Message:
-----------
hw/s390x: Fix bad mask in time2tod()
Since "s390x/tcg: avoid overflows in time2tod/tod2time", the
time2tod() function tries to deal with the 9 uppermost bits in the
time value, but uses the wrong mask for this: 0xff80000000000000 should
be used instead of 0xff10000000000000 here.
Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd
Cc: address@hidden
Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
[CH: tweaked commit message]
Signed-off-by: Cornelia Huck <address@hidden>
Commit: 41e2c56ed95db328a4e24c5756312c0158de71ce
https://github.com/qemu/qemu/commit/41e2c56ed95db328a4e24c5756312c0158de71ce
Author: Peter Maydell <address@hidden>
Date: 2018-12-20 (Thu, 20 Dec 2018)
Changed paths:
M hw/s390x/css.c
M include/hw/s390x/tod.h
Log Message:
-----------
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20181220' into staging
Two s390x bugfixes.
# gpg: Signature made Thu 20 Dec 2018 16:36:42 GMT
# gpg: using RSA key DECF6B93C6F02FAF
# gpg: Good signature from "Cornelia Huck <address@hidden>"
# gpg: aka "Cornelia Huck <address@hidden>"
# gpg: aka "Cornelia Huck <address@hidden>"
# gpg: aka "Cornelia Huck <address@hidden>"
# gpg: aka "Cornelia Huck <address@hidden>"
# Primary key fingerprint: C3D0 D66D C362 4FF6 A8C0 18CE DECF 6B93 C6F0 2FAF
* remotes/cohuck/tags/s390x-20181220:
hw/s390x: Fix bad mask in time2tod()
hw/s390/ccw.c: Don't take address of packed members
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/95de6f4b92ef...41e2c56ed95d
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 55281a: hw/s390/ccw.c: Don't take address of packed member...,
GitHub <=