[Qemu-devel] PATCH for QEMU 0.6.1 hw/openpic.c typo bug

[Marc E. Fiuczynski]

Hello,

The hw/openpic.c code may have a typo error where a constant appears to have
an extra zero in it. I.e., it is
0x800000000 but should be
0x80000000.

This is something that gcc flags as a warning.  Considering the number of
other warning messages that gcc produces, I suspect that you guys have
simply overlooked this one. Below is a diff snippet that you can feed to
patch, though, I suppose it will be easier to edit it by hand.

Cheers,
Marc



*** hw/openpic.c        12 Nov 2004 19:42:16 -0000      1.1.1.1
--- hw/openpic.c        12 Nov 2004 21:05:24 -0000      1.2
***************
*** 629,635 ****
          break;
      case 0x10: /* TIBC */
        if ((opp->timers[idx].ticc & 0x80000000) != 0 &&
!           (val & 0x800000000) == 0 &&
              (opp->timers[idx].tibc & 0x80000000) != 0)
            opp->timers[idx].ticc &= ~0x80000000;
        opp->timers[idx].tibc = val;
--- 629,635 ----
          break;
      case 0x10: /* TIBC */
        if ((opp->timers[idx].ticc & 0x80000000) != 0 &&
!           (val & 0x80000000) == 0 &&
              (opp->timers[idx].tibc & 0x80000000) != 0)
            opp->timers[idx].ticc &= ~0x80000000;
        opp->timers[idx].tibc = val;