[Qemu-devel] Re: Some patches for qemu on sparc

[Jurij Smakov]

On Sat, 11 Feb 2006, Blue Swirl wrote:

> > Thanks for your feedback. I've added additional check to dyngen.c, which 
> > checks that function has either save; in the beginning and ret; restore;
> > in the end, or ends in retl; nop;. That allowed me to get past the arm 
> > target build failure. Now it fails (during dyngen check) on ppc target, the 
> > culprit is the following function:
>
> Just keep the instruction after retl, if it's not a nop. Stack adjustments 
> could be combined someplace, but that's a problem with all architectures, not 
> just sparc.
>
> That is:
> insn1
> retl
> insn3
>
> should become:
> insn1
> insn2
>
> In some cases there is just one instruction after retl with nothing before 
> it.

Sorry, I am not familiar with qemu internals enough to understand that. It 
currently fails the build in the sanity check implemented in dyngen.c. We 
figured out so far that there might be two valid cases: save;...ret;restore;
and ....;retl;nop;. Are you saying that the function ending in 
retl;some_insn; is valid as well and the check has to be modified yet 
again to accomodate this (third) case?

Best regards,

Jurij Smakov                                        address@hidden
Key: http://www.wooyd.org/pgpkey/                   KeyID: C99E03CC