[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Updated BGR vs. RGB vga patch...

From: Leonardo E. Reiter
Subject: Re: [Qemu-devel] Updated BGR vs. RGB vga patch...
Date: Mon, 10 Apr 2006 15:11:12 -0400
User-agent: Mozilla Thunderbird 1.0.7 (X11/20051013)

Probably... I just don't know anything about SDL and I needed this patch to work right away with at least the command-line option. It's definitely deducible from X11, and that's very easy.

- Leo Reiter

malc wrote:
On Mon, 10 Apr 2006, Leonardo E. Reiter wrote:

Anyway, I didn't spend time figuring out how to query SDL for the ordering. You still have to manually pass in -bgr. The good news is that all the computation is now done at compile-time, with only very few tests done at run-time. I agree with your assessment of compile-time versus run-time options... I was merely suggesting a compromise to fend off the minor performance hit of using the old patch. But the method you suggested is much better and that's how it's implemented now.

I maybe going out on a limb here, but isn't rgb/bgr trivially deducible
from: sdl.c:screen->format->[RGBA]shift.

Leonardo E. Reiter
Vice President of Product Development, CTO

Win4Lin, Inc.
Virtual Computing from Desktop to Data Center
Main: +1 512 339 7979
Fax: +1 512 532 6501

reply via email to

[Prev in Thread] Current Thread [Next in Thread]