Re: [Qemu-devel] Patch to make configure /bin/sh compatible

[Thiemo Seufer]

Ben Taylor wrote:
> This is a patch to make configure truly /bin/sh compatible,
> as well as changing some logic to remove "echo -n" for
> output to files, as "echo -n" is not consistent among
> environments.
> 
> This is against the latest cvs branch, and I appreciate
> any feedback.

[snip]
> @@ -294,7 +295,7 @@
>          target_list="i386-user arm-user armeb-user sparc-user ppc-user 
> mips-user mipsel-user $target_list"
>      fi
>  else
> -    target_list=$(echo "$target_list" | sed -e 's/,/ /g')
> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`

A standard-conforming /bin/sh should be capable of handling this.

>  fi
>  if test -z "$target_list" ; then
>      echo "No targets enabled"
> @@ -348,12 +349,12 @@
>  # Check for gcc4
>  if test "$check_gcc" = "yes" ; then
>      cat > $TMPC <<EOF
> -#if __GNUC__ >= 4
> +#if __GNUC__ < 4
>  #error gcc4
>  #endif
>  int main(){return 0;}
>  EOF
> -    if ! $cc -o $TMPO $TMPC 2>/dev/null ; then
> +    if $cc -o $TMPO $TMPC 2>/dev/null ; then
>          echo "ERROR: \"$cc\" looks like gcc 4.x"
>          echo "QEMU is known to have problems when compiled with gcc 4.x"
>          echo "It is recommended that you use gcc 3.x to build QEMU"

This looks weird, to error out if gcc is a good version. Wouldn't
something like

gcc -dM -E -xc /dev/null |awk '{ if (/__GNUC__/) print $3 }'

be simpler to find out the gcc major version?


Thiemo