Re: [Qemu-devel] Patch submission policy? (was Re: [PATCH] SAMBA multi-share support

[Jim C. Brown]

Sorry for not replies to this earlier. It got lost in my spam folder somehow.

On Mon, May 01, 2006 at 12:29:15PM -0700, Stealth Dave wrote:
> Is there a patch submission policy for QEMU?  I see a lot of patches 
> posted to this list.  Some get accepted, some get rejected with 
> comments, and others seem to be ignored. 

Patches are suppose to be sent to this list. If its a big change, you are
suppose to split it up into smaller patches and send those (so they can be
applied one by one).

Beyond that I don't know of any rules.

When patches are ignores, that usually means that it got lost in the mail.
Thats when you have to get a little bit pushy.

> Back in February, I submitted 
> a patch which expands the SAMBA capabilities of QEMU to allow multiple 
> folders to be shared, and was backwards compatible with the old syntax. 
>  I resubmitted the patch via private email to the lead devs (Fabrice 
> and Paul, the latter I presume can be considered a lead dev as he 
> appears to have CVS commit access), but again got no feedback.
> 
> I'm perfectly willing to accept that my patch isn't good enough for 
> inclusion, or even that the new functionality is not wanted (although, 
> I'd be dissappointed).  But without any feedback whatsoever, I can't 
> make improvements and, quite frankly, am feeling a little bit left out 
> in the cold.

Agreed. Feedback about rejected patches is crucial.

BTW, You can always come into the IRC channel and ask about it there.

> 
> Regards,
> - Dave

-- 
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.