[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] patch for supporting SMB on Solaris host
From: |
Ben Taylor |
Subject: |
Re: [Qemu-devel] patch for supporting SMB on Solaris host |
Date: |
Sat, 23 Dec 2006 8:17:47 -0500 |
---- Lennert Buytenhek <address@hidden> wrote:
> On Fri, Dec 22, 2006 at 08:40:27PM -0500, Ben Taylor wrote:
>
> > - snprintf(smb_cmdline, sizeof(smb_cmdline), "/usr/sbin/smbd -s %s",
> > - smb_conf);
> > + snprintf(smb_cmdline, sizeof(smb_cmdline), "% -s %s",
> > + SMBD_BINARY, smb_conf);
>
> Doesn't look right to me? (s/%/%s/)
Good catch. otherwise, the patch is better?
Ben