Re: [Qemu-devel] [PATCH] Change the 82371SB PCI-to-ISA bridge into a82371EB

[Fabrice Bellard]

I would prefer to keep the PIIX3 for the PC until the PIIX4 is more 
tested (and implemented !). I would accept having both PIIX3 and PIIX4 
(a flag could suffice at the init).

Regards,

Fabrice.

Aurelien Jarno wrote:
> On Tue, Jan 09, 2007 at 09:03:01PM +0300, Alexander Voropay wrote:
>
> > "Aurelien Jarno" <address@hidden> wrote:
> >
> >
> > > This patch changes the 82371SB PCI-to-ISA bridge into a 82371EB.
> > >
> > > Note that the ACPI controller 
> > > implemented in QEMU is already a 82371EB.
> >
> > Shouldn't we also change all "piix3" names to "piix4" ?
> >
> > [qemu]$ find . -type f | xargs grep "piix3" | wc -l
> > 18
>
>
> You are probably right for this device, but note that the USB and the
> IDE controller are still PIIX3. And this corresponds to the emulated
> devices. Ideally it would be nice to also change them into PIIX4 by
> implementing the missing features. Some of the missing features are
> really cool, like DMA support in IDE controller.
>
> Please find below a new patch that also changes the name of the ISA
> bridge to piix4. That introduces a sequence in the patches, it needs to
> be applied after the patch "devfn number for the PIIX3 southbridge".
>
> Bye,
> Aurelien
>
>
>
> This patch changes the 82371SB PCI-to-ISA bridge into a 82371EB. There
> are no differences in the implementation, but the Malta platform needs 
> this device as there are some PCI fixup in the Linux kernel. 
>
> This should be supported without problem by the i386 and x86_64 targets
> as there is no standard PC hardware. Note that the ACPI controller 
> implemented in QEMU is already a 82371EB.
> [...]