Re: [Qemu-devel] [PATCH] siginfo fix for Darwin/Mac OS X on PowerPC and cleanup

[Pierre d'Herbemont]

On 18 janv. 07, at 23:57, Thiemo Seufer wrote:


> It might be better to keep the full set around for documentation.

It's a good point.

> > -int cpu_signal_handler(int host_signum, struct siginfo *info,
> > +int cpu_signal_handler(int host_signum, struct siginfo *pinfo,
> >                         void *puc)
> >  {
> >      struct ucontext *uc = puc;
> > +    siginfo_t *info = pinfo;
> >      unsigned long pc;
> >      int is_write;
>
> Why does this make a difference?

struct siginfo is not defined on darwin. (it works because struct  
siginfo is defined also as an anonymous structure in qemu header)

But after re-thinking, my patch is rather unelegant. I think we  
should definitely use a void * type for info, rather than using the  
anonymous struct siginfo trick. Any thought?

Pierre.