[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD
From: |
Thiemo Seufer |
Subject: |
Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD |
Date: |
Mon, 2 Apr 2007 13:41:22 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Juergen Keil wrote:
>
> > From: Thiemo Seufer <address@hidden>
> > Todd T. Fries wrote:
> > > This is relative to the 20070319 snapshot.
> > >
> > >
> > > --- dyngen-exec.h.orig Mon Feb 5 17:01:54 2007
> > > +++ dyngen-exec.h Sat Mar 10 16:39:39 2007
> ...
> > > /* XXX: This may be wrong for 64-bit ILP32 hosts. */
> > > typedef void * host_reg_t;
> > > @@ -78,11 +83,15 @@ typedef void * host_reg_t;
> > > #define UINT32_MAX (4294967295U)
> > > #define UINT64_MAX ((uint64_t)(18446744073709551615))
> > >
> > > +#ifdef __OpenBSD__
> > > +typedef struct __sFILE FILE;
> > > +#else
> > > typedef struct FILE FILE;
> > > extern int fprintf(FILE *, const char *, ...);
> > > extern int printf(const char *, ...);
> > > #undef NULL
> > > #define NULL 0
> > > +#endif
> >
> > Shouldn't this cover only the FILE typedef?
>
> Probably.
>
> My dyngen-exec.h has a similar change, when I made some NetBSD experiments:
>
> Index: dyngen-exec.h
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/dyngen-exec.h,v
> retrieving revision 1.33
> diff -u -B -r1.33 dyngen-exec.h
> --- dyngen-exec.h 30 Mar 2007 16:44:53 -0000 1.33
> +++ dyngen-exec.h 2 Apr 2007 09:42:03 -0000
> @@ -78,7 +78,11 @@
> #define UINT32_MAX (4294967295U)
> #define UINT64_MAX ((uint64_t)(18446744073709551615))
>
> +#ifdef __NetBSD__
> +typedef struct __sFILE FILE;
> +#else
> typedef struct FILE FILE;
> +#endif
I made that "#ifdef _BSD" based on the assumption it is ok for all
BSD variants, including Darwin.
Thiemo