[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] strace-like output for user-linux

From: Mulyadi Santosa
Subject: Re: [Qemu-devel] [RFC] strace-like output for user-linux
Date: Mon, 04 Jun 2007 00:41:45 +0700
User-agent: Thunderbird (X11/20070326)

Hi Stuart

I hope my little advice is correct... but overall, I think you add a nice usefuk feature here.

I'm sending this patch out for comments. It adds the capability to get
strace(1) like output from the target executable in user-linux mode.

+char *format="%s(%ld,%ld,%ld,%ld,%ld,%ld)";
+    if( scnames[i].nr == num ) {
+        if( scnames[i].format != NULL )
+            format = scnames[i].format;
+        gemu_log(format,scnames[i].name, arg1,arg2,arg3,arg4,arg5,arg6);
+ }--> don't you think we should break() here since we already found correct syscall num? otherwise we will continue the loop



reply via email to

[Prev in Thread] Current Thread [Next in Thread]