[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix TLS support on x86

From: Thiemo Seufer
Subject: Re: [Qemu-devel] [PATCH] Fix TLS support on x86
Date: Mon, 18 Jun 2007 20:21:39 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

Alexander Graf wrote:
> Hi,
> this patch is based on the NPTL/TLS patch, David Woodhouse sent to the
> list some months ago, which unfortulately did not work for me, so these
> are the fixes needed to get it working. After all there is a certain
> chance, that I got something wrong but basically it does the following:
> 1. Implement the tg_kill syscall
> 2. Set the GS shadow register according to the information
> set_thread_area receives. I'm not sure about that part, but using the
> qemu internal functions (cpu_x86_load_seg) did not work for me.
> 3. Implement the "new" (2.5.xx) TID setting features of clone()
> 4. Use clone() for forking, since fork() did not always work for me
> (especially when using TLS)

Please split the patch per-feature, and make sure it applies to CVS head.
(It fails to apply because it appears to depend on another patch which
adds fadvise64 support.) Also, keep the code formatting style the same as
the surrounding code (line length, space vs. tabs, whitespace around
parentheses, ... ).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]