[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user EFAULT implementation

From: Stuart Anderson
Subject: Re: [Qemu-devel] [PATCH] linux-user EFAULT implementation
Date: Tue, 10 Jul 2007 17:09:20 -0400 (EDT)

On Tue, 10 Jul 2007, Fabrice Bellard wrote:

I confirm that I expected g2h() to be completely removed in case the Linux user access API is used.

I agree too that it should not be used. I'm testing ARM on x86_64, and
used it in a few places to clean up some warnings. The real fix is to
change what I was doing to not need this asignment anyway. I will take
another look at how to bury this part in the copy* interfaces.

Would it be OK to use g2h() inside the implementation of copy* ?

Since you agree for the copying interface, I suggest to convert all the code to it.

OK, I'll continue in this direction, after taking a fresh look at what I
did yesterday.

Thanks for the feedback.


Stuart R. Anderson                               address@hidden
Solutions Architect                              http://www.c2.net/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                 BD03 0A62 E534 37A7 9149

reply via email to

[Prev in Thread] Current Thread [Next in Thread]