Re: [kvm-devel] [Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays

[Avi Kivity]

Blue Swirl wrote:
> On 10/14/07, Avi Kivity <address@hidden> wrote:
>   
> > Some kvm users complained that the blue and red channels are flipped on
> > their displays.  Reverting sdl.c rev 1.40 fixed that problem, so
> > apparently that commit made the problem larger than it was previously.
> >
> > Attached a patch the removes the commit and fixes the problem.  Please
> > apply.
> >     
>
> But this commit was previously reported as the best solution for OSX
> (Intel, PPC) and Linux/PPC:
> http://article.gmane.org/gmane.comp.emulators.qemu/18071
>
> What kind of machines are the users using?
>   

No idea, but I got two xdpyinfo logs and both indicated a bgr display.

Perhaps we see here a difference between how SDL behaves on different 
platforms.  Or maybe the test needs to be more subtle.

I haven't had any reports of wrong colors before; of course kvm users 
don't run Linux/PPC os OSX/anything.

--
error compiling committee.c: too many arguments to function