[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: PATCH, RFC: Slirp improvements
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] Re: PATCH, RFC: Slirp improvements |
Date: |
Wed, 24 Oct 2007 23:04:51 +0300 |
On 10/23/07, Fabrice Bellard <address@hidden> wrote:
> > I tried harder to change the SLIRP queue stuff to something saner by
> > hiding the pointer access inside inlined functions. Still when I
> > changed the 32 bit pointers to native 64 bit (or moved the pointers
> > outside the packet), qemu crashes. Must be some devilishly hidden
> > access somewhere. I already fixed one, which involved recycling port
> > number fields for buffer pointers. IMHO there should be some kind of
> > corporeal punishments mandated by law for writing this kind of mess.
> > Maybe it would even be easier to create a new userland IP stack based
> > on Linux from scratch instead of fixing this.
> >
> > I think I'll just commit in the log part, unless there are objections.
>
> IMHO you should add a context in the 'struct socket' structure so that
> you can avoid adding a context in all the functions manipulating this
> structure. The same holds for mbuf.
That way some changes could be avoided, maybe gain some performance.
Somehow I feel this reverses the hierarchy, though.
I extracted the logging parts and safest fixes into two patches. Comments?
slirp_const_etc.diff
Description: Text Data
slirp_debug.diff
Description: Text Data