Re: [Qemu-devel] [PATCH] strace rework

[Thayne Harbaugh]

On Sat, 2007-10-27 at 14:26 +0100, Thiemo Seufer wrote:
> Thayne Harbaugh wrote:
> > This is a rework of Stuart Anderson's strace patch.  I've fixed
> > target-to-host and host-to-target syscall lookups so that the proper
> > host or target errno is returned.
> 
> It didn't build for me due to the a missing target_to_host_errno
> function.

This isn't obvious to me.  It also doesn't appear that you included this
error in the output you sent.

>  Could you also have a look at the compiler warnings
> from strace.c? I see e.g.:

<miles of warnings deleted>

Thank you for sending me the warnings.  I've reworked it so that
function arguments are passed correctly, target addresses have access
checked and locked and that proper print format codes are used.

Attached is the new version.  Please send me feedback.

Thank you.

05_strace.patch
Description: Text Data