[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Removal of some target CPU macros

From: Fabrice Bellard
Subject: [Qemu-devel] Removal of some target CPU macros
Date: Wed, 07 Nov 2007 19:32:02 +0100
User-agent: Thunderbird (X11/20070212)

I noticed that some target CPUs macros have been added while they do not
seem necessary. I don't like that because it introduces more #ifdefs
which prevent making a version supporting simultaneously all the CPUs.

In particular I saw the following:

- TARGET_MIPSN32 : it is always combined with TARGET_MIPS64 in
target-mips/. If its only usage is to select a different Linux ABI, then
I suggest keeping TARGET_MIPS64 and using another define to choose that.

- TARGET_PPC64H, TARGET_PPCEMB : I see no reason why they cannot be
handled dynamically as the other PowerPC CPU types, provided that
TARGET_PPC64 is defined. Is it the long term plan ?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]