Re: [Qemu-devel] [PATCH 2/2][UPDATE] Add arg -drive to define new drive with more features

[Laurent Vivier]

Le mardi 13 novembre 2007 à 22:50 +0200, Blue Swirl a écrit :
> On 11/13/07, Laurent Vivier <address@hidden> wrote:
> > Attached is an updated patch (corrected as you want and with more check
> > on -drive arguments)
> 
> Sparc64 didn't compile until I added a MAX_IDE_BUS #define.
> 

Right. Do you know why "make" doesn't compile "hw/sun4u.c" ?

> SS-600MP case is still missing from vl.c and the -drive help text is
> longer than 80 chars.

I missed it should use SCSI by default. Corrected.
I've corrected help text too.

> I'd prefer a space after 'for' and 'if', though these styles aren't
> very consistently used in the original files.

I prefer too, but when I modify a file I take the style I find around
the lines I modify...

> Good news is that after adding the #define, patched Qemu seems to
> work. I tested briefly both Sparc32 and Sparc64.

Great.

Thank you for your help,
Laurent
-- 
------------- address@hidden  --------------
       "Any sufficiently advanced technology is
  indistinguishable from magic." - Arthur C. Clarke

signature.asc
Description: Ceci est une partie de message numériquement signée