Re: [Qemu-devel] another patch against head

[Johannes Schindelin]

Hi,

On Wed, 28 Nov 2007, Samuel Thibault wrote:

> Johannes Schindelin, le Wed 28 Nov 2007 14:01:21 +0000, a ?crit :
> > On Wed, 28 Nov 2007, Samuel Thibault wrote:
> > 
> > > Johannes Schindelin, le Wed 28 Nov 2007 12:49:34 +0000, a ?crit :
> > > > On Tue, 27 Nov 2007, Hotmail wrote:
> > > > 
> > > > > The following is another patch against the head that lets me build it 
> > > > > on 
> > > > > Windows, as well as makes the adlib.c file debuggable.
> > > > > 
> > > > > Index: Makefile
> > > > > ===================================================================
> > > > > RCS file: /sources/qemu/qemu/Makefile,v
> > > > > retrieving revision 1.136
> > > > > diff -r1.136 Makefile
> > > > > 17a18,20
> > > > > > ifdef CONFIG_WIN32
> > > > > > LIBS= -lmingw32 -mno-cygwin
> > > > > > else
> > > > > 18a22
> > > > > > endif
> > > > 
> > > > So you build it in Cygwin, not "on Windows".
> > > 
> > > Not exactly. -mno-cygwin means that he used the cygwin-provided gcc, but
> > > provide a non-cygwin binary that can be shipped without extra dlls.
> > 
> > And how exactly does that differ from what I said?  It is building in 
> > Cygwin.
> 
> With the MinGW headers. That makes a big difference.
> Compiling in cygwin with -mno-cygwin is almost the same as compiling
> with MinGW tools (the difference mostly lies in Makefile and shell
> script subtleties)

Okay, I failed again to make myself understood.

If you say "it fixes building on Windows", while many people have no 
problem whatsoever building it with MinGW, and other people who might want 
to build it with Visual Studio or Borland or whatever will still have a 
ton of problems, is ever so _slightly_ misleading.

Okay?

Thanks,
Dscho