qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to pri


From: Magnus Damm
Subject: Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t
Date: Fri, 30 Nov 2007 14:36:32 +0900

On Nov 19, 2007 6:18 AM, Carlo Marcelo Arenas Belon
<address@hidden> wrote:
> The following patch changes the formatting string from %08x to TARGET_FMT_plx
> to accommodate for compilation in 64bit hosts and that manifests with the
> following warning :
>
>   qemu/hw/sh7750.c: In function `error_access':
>   qemu/hw/sh7750.c:186: warning: unsigned int format, different type arg (arg 
> 5)
>   qemu/hw/sh7750.c: In function `ignore_access':
>   qemu/hw/sh7750.c:192: warning: unsigned int format, different type arg (arg 
> 5)

This patch works fine on 32 bit x86 hosts. Please apply.

> Index: sh7750.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/sh7750.c,v
> retrieving revision 1.11
> diff -u -r1.11 sh7750.c
> --- sh7750.c    17 Nov 2007 17:14:48 -0000      1.11
> +++ sh7750.c    18 Nov 2007 21:08:37 -0000

Could you please create the diff from the top level directory next
time? That way it can be applied with patch -p0 or -p1 directly in the
top level directory which makes patch handling much easier. Thanks!

/ magnus




reply via email to

[Prev in Thread] Current Thread [Next in Thread]