Re: [Qemu-devel] [PATCH] Capture network traffic to a tcpdump file - updated

[Anthony Liguori]

Paul Brook wrote:
> On Monday 10 December 2007, Anthony Liguori wrote:
>   
> > Balazs Attila-Mihaly (Cd-MaN) wrote:
> >     
> > > Here goes v0.2 for my patch :-)
> > > Changes
> > > - now the option is a separate command line switch:
> > >   -net capture,vlan=2,file=test.pcap
> > >       
> > Is it really necessary/useful to specify this on the command line since
> > it can be controlled from the monitor?
> >     
>
> By that argument you could remove half the rest of the commandline options 
> (e.g. the USB options).
>   

I was thinking about the use-case.  For instance, you probably want to 
start and end the capture at specific times.  I don't think the common 
case it trapping traffic for the entire duration the guest is running.

Regards,

Anthony Liguori

> I think it would be good to expose the whole -net functionality via the 
> monitor, rather than have a special hack for -net monitor. Obviously some 
> functionality would only be usable via the commandline (e.g. non-hotplug 
> NICs)
>   

> Paul
>
>