qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows


From: Johannes Schindelin
Subject: Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows
Date: Wed, 9 Jan 2008 12:27:30 +0000 (GMT)
User-agent: Alpine 1.00 (LSU 882 2007-12-20)

Hi,

On Wed, 9 Jan 2008, Laurent Vivier wrote:

> but "-hda" is an alias for "-drive file="%s",index=%d,media=disk".

It appears to me as if "-hda" is implemented suboptimally, then.  In 
particular, drive_add() should be able to get a separate "file" parameter, 
which can be overridden by the "fmt" parameter.  Of course, this would 
mean that the global drives_opt[] array should not have element type 
"char", but a struct.

It is a pity that there is DWIMery going on in drive_init(), needing the 
other options to be parsed already, otherwise drive_add() could have been 
replaced by calls to drive_init().

Ciao,
Dscho




reply via email to

[Prev in Thread] Current Thread [Next in Thread]