Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

[Laurent Vivier]

Le mercredi 09 janvier 2008 à 13:59 +0000, Johannes Schindelin a écrit :
> Hi,
> 
> On Wed, 9 Jan 2008, Laurent Vivier wrote:
> 
> > Le mercredi 09 janvier 2008 à 13:27 +0000, Johannes Schindelin a écrit :
> > > Hi,
> > > 
> > > On Wed, 9 Jan 2008, Laurent Vivier wrote:
> > > 
> > > > Le mercredi 09 janvier 2008 à 12:27 +0000, Johannes Schindelin a écrit :
> > > > 
> > > > > On Wed, 9 Jan 2008, Laurent Vivier wrote:
> > > > > 
> > > > > > but "-hda" is an alias for "-drive file="%s",index=%d,media=disk".
> > > > > 
> > > > > It appears to me as if "-hda" is implemented suboptimally, then.  
> > > > > In particular, drive_add() should be able to get a separate "file" 
> > > > > parameter, which can be overridden by the "fmt" parameter.  Of 
> > > > > course, this would mean that the global drives_opt[] array should 
> > > > > not have element type "char", but a struct.
> > > > 
> > > > This introduces complexity and special cases I don't want to 
> > > > manage...
> > > 
> > > The problem is that you introduced a regression, as you can see by the 
> > > size of this thread.
> > 
> > The solution is very simple to restore original behavior: don't manage 
> > filename with spaces.
> 
> I disagree with the term "solution" in this context.  I call a thing like 
> this "regression".

It's not a regression because originally qemu was not able to manage
spaces in filename.
I broke things ("\" management) by trying to manage spaces.

Laurent
-- 
----------------- address@hidden  ------------------
  "La perfection est atteinte non quand il ne reste rien à
ajouter mais quand il ne reste rien à enlever." Saint Exupéry

signature.asc
Description: Ceci est une partie de message numériquement signée