qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH, RFC, WIP] TCG for Qemu target Sparc32/64


From: Fabrice Bellard
Subject: [Qemu-devel] Re: [PATCH, RFC, WIP] TCG for Qemu target Sparc32/64
Date: Sat, 23 Feb 2008 19:23:49 +0100
User-agent: Thunderbird 1.5.0.9 (X11/20070212)

Blue Swirl wrote:
> The attached patch enables most TCG ops for Qemu Sparc32/64 target.
> Sparc32 softmmu and linux-user are OK, but Sparc64 and Sparc32plus
> targets do not work.
> 
> Comments?
> 
> It would be nice to get rid of T2 usage in std (also stda and
> casa/casxa) but I don't know how to pass a 64-bit value from legacy op
> to TCG stores and loads on a 32-bit target and host.
[...]

Also don't forget that T2 is used in CPU restore state to handle delay
slots. This part of the SPARC target is tricky and should be simplified.

Another point is that you should define TCG globals for each SPARC GPR.
It was not done for i386 because I feared performance regressions when
accessing to 16 bit or 8 bit sub-registers. On SPARC you do not have
this issue.

Regarding the generic "xxx_tl" defines, I did not move it into TCG
because I wanted TCG to be target independent. Since it is no longer the
case because of the target memory access instructions, I think it is a
good idea now. But do not mix the target specific defines with target
independent defines (in tcg-op.h there is a specific section for target
specific defines).

Regards,

Fabrice.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]