[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
|
From: |
Fabrice Bellard |
|
Subject: |
Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl... |
|
Date: |
Tue, 11 Mar 2008 23:43:47 +0100 |
|
User-agent: |
Thunderbird 1.5.0.9 (X11/20070212) |
Aurelien Jarno wrote:
> Fabrice Bellard a écrit :
>> IMHO it would be much simpler to do all the tests in the block format
>> handlers.
>>
>
> Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ?
I suggest reverting the patch and writing correct tests in
block-{qcow,qcow2,vmdk}.c. BTW, bs->total_sectors is not a good
indicator of the device size in case of removable devices for example.
Fabrice.