Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer size.

[Ian Jackson]

Aurelien Jarno writes ("Re: [Qemu-devel] [PATCH] Improve DMA transfers by 
increasing the buffer size."):
> On Wed, Mar 26, 2008 at 04:35:00PM +0000, Ian Jackson wrote:
> Content-Description: message body text
> > +#define IDE_DMA_BUF_SIZE 131072
> 
> Wouldn't it be better to define this value in number of sectors? This
> would avoid a few divisions in the code, and anyway the code handling
> DMA transfers is working with a number of sectors, not a number of 
> bytes.

I don't have much of an opinion about what units it should be in.  The
divisions are just at compile-time of course.

If you prefer I'll send another version with it done in sectors :-).

Ian.