|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2) |
Date: | Mon, 07 Apr 2008 08:22:23 -0500 |
User-agent: | Thunderbird 2.0.0.12 (X11/20080227) |
Paul Brook wrote:
On Friday 04 April 2008 23:02:50 Anthony Liguori wrote:uint32_t is the wrong type to use to represent physical addresses. .... /* XXX: temporary until new memory mapping API */ -uint32_t cpu_get_physical_page_desc(target_phys_addr_t addr) +ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr)The returned value is still a uint32_t. Changing the function prototype without fixing that is just deluding yourself.
It's a ram_addr_t in KVM and the large mem patch I posted long ago changes it to a ram_addr_t. But you're right, it doesn't belong in this series.
Regards, Anhtony Liguori
Paul
[Prev in Thread] | Current Thread | [Next in Thread] |