[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [4249] Improve audio api use in WM8750.
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [4249] Improve audio api use in WM8750. |
Date: |
Fri, 25 Apr 2008 03:10:07 +0200 |
User-agent: |
Thunderbird 2.0.0.12 (X11/20080226) |
andrzej zaborowski wrote:
> On 25/04/2008, Jan Kiszka <address@hidden> wrote:
>> > The checking of whether the guest filled enough data happens in
>> > wm8750_dac_dat(), I don't see why do it second time here. The only
>> > place we need an additional check is before s->dat_req call, which you
>> > remove.
>>
>> True, that's redundant, let's fix it this way (this even obsoletes the
>> flush in out_cb):
>
> Ok, although I insist that it doesn't obsolete the check in out_cb
> (hence why I added it). Imagine s->req_out was 5000, and the guest
> already wrote 1000 bytes. Now suddenly audio API calls out_cb with
> free_b == 1500. In this case we have half of the buffer ready to
> write, *before* we call s->data_req.
Yes, buffer/2 was attacking the symptom, wrongly, see my other mail.
> BTW I just committed a change to the MusicPal LCD, please check if it
> still works. Thanks.
Still fine!
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [4249] Improve audio api use in WM8750., Andrzej Zaborowski, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., Jan Kiszka, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., andrzej zaborowski, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., Jan Kiszka, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., Jan Kiszka, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., andrzej zaborowski, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., Jan Kiszka, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., Jan Kiszka, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., andrzej zaborowski, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., andrzej zaborowski, 2008/04/24
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750.,
Jan Kiszka <=
- Re: [Qemu-devel] [4249] Improve audio api use in WM8750., andrzej zaborowski, 2008/04/24