qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] bdrv_flush error handling


From: andrzej zaborowski
Subject: Re: [Qemu-devel] Re: [PATCH] bdrv_flush error handling
Date: Sat, 26 Apr 2008 17:15:19 +0200

On 28/03/2008, Ian Jackson <address@hidden> wrote:
> On the 20th of February I wrote:
>  > bdrv_flush is declared to return void, but this is wrong because it
>  > means that the implementations have nowhere to report their errors.
>  > Indeed, the implementations generally ignore errors.
>  >
>  > This patch corrects this by making it return int (implicitly, either 0
>  > or -errno, as for other similar functions).  All of the
>  > implementations and callers are adjusted too.
>
>  There was some discussion which I think concluded that this change was
>  good but the patch doesn't seem to have been applied.

It doesn't seem to apply against qemu, I could modify it but I don't
know how block-raw-win32.c reports errors.

Regards




reply via email to

[Prev in Thread] Current Thread [Next in Thread]