qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT)


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT)
Date: Tue, 06 May 2008 18:56:42 +0200
User-agent: Thunderbird 2.0.0.12 (X11/20071114)

Blue Swirl schrieb:
Well, the patch looks OK. But I try to test the patches before I
commit and for this I don't know how. Could you give some example test
cases?

If you want to test that the patch fixes what it promises you only have to create a qcow or qcow2 image and start qemu with cache=off for this image. This will fail without the patch, and it should work with the patch applied. This covers the simple case. For the aio part of the patch you can try saving/loading of snapshots. Normal qcow2 operation doesn't trigger the aio code path.

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]