qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_D


From: Jamie Lokier
Subject: Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_DIRECT)
Date: Wed, 21 May 2008 13:26:29 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

Kevin Wolf wrote:
> Anthony Liguori schrieb:
> >I don't think it's that important to try and guess the right alignment 
> >size, 512 is probably usually sufficient, but spreading alignment 
> >requirements of 512 throughout QEMU code is a bad idea because this is 
> >something that's very hardware/OS specific.
> 
> So better introduce a #define in block.h?
> 
> >For people that care about data integrity, we should be using O_SYNC, 
> >not O_DIRECT anyway.
> 
> Should we implement an option for O_SYNC then? (not in this patch, of 
> course)

Why would O_SYNC be better than O_DIRECT?

-- Jamie




reply via email to

[Prev in Thread] Current Thread [Next in Thread]