[PATCH] Re: [Qemu-devel] VNC Segfault : was Re: Segfault installing Windows XP 32 Bit guest on Linux 64Bit host

[Brad Campbell]

Brad Campbell wrote:

> Patch attached.

*fixed* patch attached.. <sigh>

Brad
--
"Human beings, who are almost unique in having the ability
to learn from the experience of others, are also remarkable
for their apparent disinclination to do so." -- Douglas Adams

Index: vnc.c
===================================================================
--- vnc.c       (revision 4632)
+++ vnc.c       (working copy)
@@ -307,12 +307,14 @@
     ds->width = w;
     ds->height = h;
     ds->linesize = w * vs->depth;
-    if (vs->csock != -1 && vs->has_resize && size_changed) {
-       vnc_write_u8(vs, 0);  /* msg id */
-       vnc_write_u8(vs, 0);
-       vnc_write_u16(vs, 1); /* number of rects */
-       vnc_framebuffer_update(vs, 0, 0, ds->width, ds->height, -223);
-       vnc_flush(vs);
+    if (size_changed) {
+        if (vs->csock != -1 && vs->has_resize) {
+           vnc_write_u8(vs, 0);  /* msg id */
+           vnc_write_u8(vs, 0);
+           vnc_write_u16(vs, 1); /* number of rects */
+           vnc_framebuffer_update(vs, 0, 0, ds->width, ds->height, -223);
+           vnc_flush(vs);
+       }
        vs->width = ds->width;
        vs->height = ds->height;
     }