Re: [Qemu-devel] [patch] Make qemu-nbd compile on OS X

[M. Warner Losh]

In message: <address@hidden>
            "Daniel P. Berrange" <address@hidden> writes:
: On Mon, Jun 02, 2008 at 11:44:17AM -0600, C.W. Betts wrote:
: > The following is a patch to make qemu-nbd compile on Mac OS X Leopard  
: > (any other versions are untested)
: > 
: > Index: qemu-nbd.c
: > ===================================================================
: > --- qemu-nbd.c      (revision 4654)
: > +++ qemu-nbd.c      (working copy)
: > @@ -21,7 +21,11 @@
: >  #include "block_int.h"
: >  #include "nbd.h"
: > 
: > +#ifdef __APPLE__
: > +#include <malloc/malloc.h>
: > +#else
: >  #include <malloc.h>
: > +#endif
: 
: 
: The include of malloc.h looks rather bogus to me. malloc() is part
: of stdlib.h, and is not even used in this file anyway. It compiles fine
: on Linux if you remove include of malloc.h entirely

Yes.  Years ago, malloc.h was typically needed for SunOS 4.x
compatibility.  Once malloc was codified to live in stdlib.h, malloc.h
was deprecated.

Warner