[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] gdbstub: monitor fixes v3

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] gdbstub: monitor fixes v3
Date: Tue, 03 Jun 2008 16:12:28 -0500
User-agent: Thunderbird (X11/20080501)

Jason Wessel wrote:
Based on some comments in the qemu irc channel, here is a revised
implementation of gdb monitor pass through patches.

At a future time if it is truly "high value" the gdb specific monitor
commands will be migrated into the qemu monitor, OR at such time that
the user emulation begins to use the monitor.  Presently, the only
user of the gdb specific variables is a debugger and the controls
exist to alter the behavior from the debugger, even if you have to
find the debugger console window some where in a debugger UI...

I would guess the average user never uses the debugger.  Out of the
small community of users that use the debugger probably even fewer
will use these new controls. These type of controls are intended for
extremely low level debugging, hence the reason they exist in the
"Advanced Section" in the first place :-)

please apply in order:

Please separate patches in individual emails in the future.

In general, I don't like the approach this takes using the monitor multiplexing support to simulate the ability to have multiple monitors. Either we should properly support having multiple monitors, or we should dedicate the monitor to the gdb interface.

That is, I'd rather see this patch implemented as -monitor gdb then taking over the monitor like it does. I'm concerned that the multiplexing is going to break monitor redirection when the GDB session is active.


Anthony Liguori



reply via email to

[Prev in Thread] Current Thread [Next in Thread]