[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand |
|
Date: |
Thu, 05 Jun 2008 00:29:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Thiemo Seufer wrote:
> Jan Kiszka wrote:
>> Fabrice Bellard wrote:
>>> Hi,
>>>
>>> I tend to dislike such macros...
>> Why?
>
> IHMO it isn't a useful abstraction (and therefore code obfuscation).
What possible misunderstandings do you see in its naming? Granted, I'm
used to it as this scheme is standard under Linux (with variations for
CPU hotplugging).
The code becomes shorter and thus quicker graspable IMO. And I guess the
more QEMU heads for SMP guests, there more often this pattern will
occur. My debugger SMP fix already comes with 5 more use cases.
Jan
signature.asc
Description: OpenPGP digital signature