|
From: | Kevin Wolf |
Subject: | [Qemu-devel] Re: [RESENT][PATCH 1/2] Log reset events |
Date: | Tue, 24 Jun 2008 11:07:36 +0200 |
User-agent: | Thunderbird 2.0.0.12 (X11/20071114) |
Jan Kiszka schrieb:
Index: b/target-i386/helper.c =================================================================== --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -383,6 +383,11 @@ void cpu_reset(CPUX86State *env)memset(env, 0, offsetof(CPUX86State, breakpoints)); + if (loglevel & CPU_LOG_RESET) {+ fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index); + cpu_dump_state(env, logfile, fprintf, X86_DUMP_FPU | X86_DUMP_CCOP); + } + tlb_flush(env, 1);env->old_exception = -1;
I'd say you want to have the memset after the CPU dump, otherwise the dump is quite boring. ;-) Did you change that by intention? Your last patch still had the memset after the dump.
You can add a Signed-off-by: Kevin Wolf <address@hidden> to the next version of the patch.
Kevin
[Prev in Thread] | Current Thread | [Next in Thread] |