qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [4799] Add instruction counter.


From: Paul Brook
Subject: Re: [Qemu-devel] [4799] Add instruction counter.
Date: Sun, 29 Jun 2008 13:28:35 +0100
User-agent: KMail/1.9.9

> +    int done_init = 0;
> +    if (done_init)
> +        return;
> +    cpu_env = tcg_global_reg_new(TCG_TYPE_PTR, TCG_AREG0, "env");
> +    done_init = 1;
> +}
>
> - done_init is on the stack, thus will never be 1.

Fixed.

> - why isn't this variable / code shared with other targets (can see the
> exact same code in Alpha target...) ?

Maybe. Most targets have many globals and cpu_env is the only one that's 
really target independent. alpha and ppc are only the same because they still 
haven't been converted to TCG.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]