Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver

[Markus Armbruster]

Gerd Hoffmann <address@hidden> writes:

> Anthony Liguori wrote:
>> Gerd Hoffmann wrote:
>>> +++ b/hw/xen-framebuffer.c
>>> @@ -0,0 +1,925 @@
>>> +/*
>>> + *  xen paravirt framebuffer backend
>> 
>> No copyright?
>> 
>
> Well, qemu-dm's xenfb.c which I used as base didn't have one.
> Guess most of this is Markus' code (CC'ed).
>
> cheers,
>   Gerd

Development history has been a bit more complicated than that :)

* Initial version: Anthony Liguori <address@hidden>

  The link[*] to it has gone stale.  I don't think it had a copyright
  in the file that eventually mutated into the one we're discussing.

* Hacked into shape: me (xen-unstable changeset 12678).  No copyright
  in the source file.  Changeset carries:

  Signed-off-by: Markus Armbruster <address@hidden>
  Signed-off-by: Anthony Liguori <address@hidden>

* Additional changes (use "hg log tools/xenfb in xen-unstable" to list
  them) by:

  Signed-off-by: Daniel P. Berrange <address@hidden>
  Signed-off-by: Gerd Hoffmann <address@hidden>
  Signed-off-by: Hirofumi Tsujimura <address@hidden>
  Signed-off-by: Ian Campbell <address@hidden>
  Signed-off-by: John Levon <address@hidden>
  Signed-off-by: Junko Ichino <address@hidden>
  Signed-off-by: Keir Fraser <address@hidden>
  Signed-off-by: Markus Armbruster <address@hidden>
  Signed-off-by: Steven Smith <address@hidden>
  Signed-off-by: Takanori Kasai <address@hidden>
  Signed-off-by: Tsunehisa Doi <address@hidden>

* Transformed from a separate program into a part of ioemu-dm:

  Signed-off-by: Daniel P. Berrange <address@hidden>

* Additional changes (use "hg log tools/xenfb" to list them) by:

  Signed-off-by: Daniel P. Berrange <address@hidden>
  Signed-off-by: Keir Fraser <address@hidden>
  Signed-off-by: Keir Fraser <address@hidden>
  Signed-off-by: Markus Armbruster <address@hidden>
  Signed-off-by: Pat Campbell <address@hidden>
  Signed-off-by: Samuel Thibault <address@hidden>
  Signed-off-by: Stefano Stabellini <address@hidden>

* Transformed to work on top of his common backend driver code in
  upstream QEMU:

  Signed-off-by: Gerd Hoffmann <address@hidden>

I guess a copyright note should include at least Anthony, me, Dan,
Pat, Gerd (in order of first major contribution).  Perhaps something
like:

 * Copyright (C) 2005-2006 Anthony Liguori <address@hidden>
 * Copyright (C) 2006-2008 Red Hat, Inc., Markus Armbruster <address@hidden>,
 *     Daniel P. Berrange <address@hidden>,
 *     Gerd Hoffmann <address@hidden>
 * Copyright (C) 2008 Pat Campbell <address@hidden>

Apologies if I missed someone!

[*] http://www.cs.utexas.edu/users/aliguori/xen-vfb-20060124.bundle