[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver.
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver. |
Date: |
Mon, 4 Aug 2008 20:26:42 +0300 |
On 8/4/08, Gerd Hoffmann <address@hidden> wrote:
> +/* i386 protocol version */
> +#pragma pack(push, 4)
What's wrong with __attribute__(__aligned__)?
> + * FIXME: the code is designed to handle multiple outstanding
> + * requests (using aio or using threads), which isn't used right
> + * now due to limitations of the qemu block driver interface.
Yes, what happened to vectored DMA patches?
> + RING_PUSH_RESPONSES_AND_CHECK_NOTIFY(&blkdev->rings.common,
> send_notify);
EUGLY_LONG_NAME_WITH_ALL_CAPS
> + mode = O_RDONLY;
> + qflags = BDRV_O_RDONLY;
> + info |= VDISK_READONLY | VDISK_REMOVABLE | VDISK_CDROM;
Does this mean that all read-only disks are assumed to be CDROMs or
that all removable disks are read-only?
Why IF_XEN?
Why different protocols for i386 and x86_64? Would I need to add
Sparc32 and Sparc64 versions some day?
- [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Gerd Hoffmann, 2008/08/04
- [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support, Gerd Hoffmann, 2008/08/04
- [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Gerd Hoffmann, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver.,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Samuel Thibault, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Anthony Liguori, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Gerd Hoffmann, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Paul Brook, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Gerd Hoffmann, 2008/08/05
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Blue Swirl, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Gerd Hoffmann, 2008/08/05
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Samuel Thibault, 2008/08/04
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Gerd Hoffmann, 2008/08/05
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Samuel Thibault, 2008/08/05