Re: [Qemu-devel] [patch 2/5][v2] Divide get_cluster_offset()

[Kevin Wolf]

Laurent Vivier schrieb:
> Le mardi 05 août 2008 à 17:13 +0200, Kevin Wolf a écrit :
> [...]
>> Why are you moving that code around? I don't think it's needed for the
>> get_cluster_offset/allocate_cluster_offset split. You're just
>> duplicating the write and return.
> 
> You're right but doing this here allows to clearly split compressed case
> and normal case. It is doing for following patches.

Yes, I've noticed that now by myself. Seems I have to look at the
complete patch series until I can tell if this makes sense. ;-)

For now, I assume you have good reasons to do it this way. So take it as
an Ack for this patch as it is.

Kevin