[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmis

From: Anthony Liguori
Subject: Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes
Date: Sat, 09 Aug 2008 13:24:07 -0500
User-agent: Thunderbird (X11/20080501)

Blue Swirl wrote:

I made a series of patches that add -Wstrict-prototypes to the CFLAGS
and then -Wmissing-prototypes, both of which are enabled by Xen. I
also fixed most warnings generated -Wstrict-prototypes and some of
them for the -Wmissing-prototypes case.

Compiling with -Wstrict-prototypes produces only one extra warning. I
think this flag should be enabled.

As long as the plan is to fix all of those warnings, I think it's a good idea.


Anthony Liguori

But dyngen targets spew a lot of noise with -Wmissing-prototypes so
I'm not proposing to add that (or maybe that should be coupled with
CONFIG_DYNGEN_OP). This also meant that I did not care enough to fix
all warnings. The current warning fix should be safe to apply anyway.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]